-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added open recent functionality #551
Conversation
@@ -73,6 +73,7 @@ def __init__(self, parent, projectFolder, jsonPath, loadValue, logger): | |||
self.projectFolder = projectFolder | |||
|
|||
self.diagramName = os.path.split(self.projectFolder)[-1] + ".json" | |||
self.diagramPath = os.path.join(self.projectFolder, self.diagramName) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's discuss this refactoring choice, as it may lead to incremental improvements.
project = _ccl.value(maybeCancelled) | ||
|
||
self._resetEditor(project) | ||
|
||
if isinstance(project, _prj.MigrateProject): | ||
self.editor.save() | ||
|
||
def openRecentFile(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like duplication of the usual functionality when opening another project.
Can this be integrated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not exactly, we can defintely extract message box
Quality Gate passedIssues Measures |
No description provided.